Issue 174349: Add support for replace infobar. The lack of this was a top mac crasher....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174349: Add support for replace infobar. The lack of this was a top mac crasher.... (Closed)

Created:
11 years, 4 months ago by Erik does not do reviews

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman, pink (ping after 24hrs), rohitrao (ping after 24h)

CC:
chromium-reviews_googlegroups.com, John Grabowski, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Add support for replace infobar. The lack of this was a top mac crasher. BUG=19728 TEST=install two themes without dismissing info bar. then dismiss the info bar. It shouldn't crash. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24234

Patch Set 1 #

Total comments: 2

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -1 line)			Patch
	M	chrome/browser/cocoa/infobar_container_controller.h	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	chrome/browser/cocoa/infobar_container_controller.mm	View		4 chunks	+19 lines, -1 line	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Aaron Boodman

lgtm http://codereview.chromium.org/174349/diff/1/2 File chrome/browser/cocoa/infobar_container_controller.mm (right): http://codereview.chromium.org/174349/diff/1/2#newcode173 Line 173: // TODO(port): This should avoid animation when ...

11 years, 4 months ago (2009-08-24 21:29:07 UTC) #2

rohitrao (ping after 24h)

11 years, 4 months ago (2009-08-25 15:57:35 UTC) #3

LGTM

http://codereview.chromium.org/174349/diff/1/2
File chrome/browser/cocoa/infobar_container_controller.mm (right):

http://codereview.chromium.org/174349/diff/1/2#newcode173
Line 173: // TODO(port): This should avoid animation when we add it.
On 2009/08/24 21:29:07, Aaron Boodman wrote:
> Cool, thanks for adding this TODO

Feel free to assign this TODO to me.

Expand Messages | Collapse Messages