Issue 174342: Fix a bug where we reused a va_list across multiple calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174342: Fix a bug where we reused a va_list across multiple calls. (Closed)

Created:
11 years, 4 months ago by Dean McNamee

Modified:
9 years, 7 months ago

Reviewers:
brettw, Evan Martin

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Fix a bug where we reused a va_list across multiple calls. The problem is that va_arg modifies the va_list so that the next call to va_arg returns the next argument. It looks like this code had attempted to not reuse the list by making a copy, but it passed the original instead of the copy.

Patch Set 1 #

Patch Set 2 : comment #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -9 lines)			Patch
	M	base/string_util.cc	View	1	2 chunks	+9 lines, -9 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

http://codereview.chromium.org/174342/diff/1002/4 File base/string_util.cc (right): http://codereview.chromium.org/174342/diff/1002/4#newcode996 Line 996: result = vsnprintfT(&mem_buf[0], mem_length, format, ap_copy); (note for ...

11 years, 4 months ago (2009-08-24 20:28:50 UTC) #3

Whoops! LGTM

Expand Messages | Collapse Messages