Issue 174317: Reapply ARM root array change to reduce const pool size...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174317: Reapply ARM root array change to reduce const pool size... (Closed)

Created:
11 years, 4 months ago by Erik Corry

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Reapply ARM root array change to reduce const pool size by using r10 to point to a list of common root objects. This time we also disable a debugger test on ARM that has never worked, but with this change sometimes crashes. Committed: http://code.google.com/p/v8/source/detail?r=2744

Patch Set 1 #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+179 lines, -110 lines)			Patch
M	src/arm/builtins-arm.cc	View	6 chunks	+12 lines, -8 lines	0 comments	Download
M	src/arm/cfg-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/codegen-arm.cc	View	31 chunks	+64 lines, -41 lines	0 comments	Download
M	src/arm/disasm-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/arm/ic-arm.cc	View	6 chunks	+14 lines, -7 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	1 chunk	+4 lines, -0 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View	5 chunks	+16 lines, -5 lines	0 comments	Download
M	src/arm/stub-cache-arm.cc	View	4 chunks	+10 lines, -5 lines	0 comments	Download
M	src/arm/virtual-frame-arm.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	src/assembler.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/assembler.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/heap.h	View	3 chunks	+23 lines, -20 lines	0 comments	Download
M	src/serialize.cc	View	2 chunks	+14 lines, -10 lines	0 comments	Download
M	test/cctest/test-disasm-arm.cc	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	test/cctest/test-serialize.cc	View	2 chunks	+4 lines, -4 lines	1 comment	Download
M	test/mjsunit/mjsunit.status	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

11 years, 4 months ago (2009-08-24 09:22:50 UTC) #2

LGTM

http://codereview.chromium.org/174317/diff/1/3
File test/cctest/test-serialize.cc (right):

http://codereview.chromium.org/174317/diff/1/3#newcode133
Line 133: encoder.Encode(ExternalReference::new_space_start().address()));
Maybe add check of the root table.

Expand Messages | Collapse Messages