Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 174303: Modify the RenderThread to track the number of widgets... (Closed)

Created:
11 years, 4 months ago by Mike Belshe
Modified:
9 years, 5 months ago
CC:
chromium-reviews_googlegroups.com, brettw, jam
Visibility:
Public.

Description

Modify the RenderThread to track the number of widgets and "hidden widgets" which are running through that thread. By knowing the if the widgets are all hidden, the thread can accurately inform V8 when it is idle so that V8 can better cleanup unused memory when idle. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24227

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+115 lines, -13 lines) Patch
M chrome/renderer/mock_render_thread.h View 2 3 4 5 6 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/renderer/render_thread.h View 1 2 3 4 5 6 4 chunks +25 lines, -1 line 0 comments Download
M chrome/renderer/render_thread.cc View 1 2 3 4 5 6 7 6 chunks +61 lines, -4 lines 0 comments Download
M chrome/renderer/render_widget.h View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/renderer/render_widget.cc View 1 2 3 4 5 6 5 chunks +18 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mike Belshe
11 years, 4 months ago (2009-08-22 10:32:27 UTC) #1
darin (slow to review)
Looks good, but I'm not so sure about running a repeating 1 sec timer in ...
11 years, 4 months ago (2009-08-22 14:57:05 UTC) #2
Mike Belshe
On 2009/08/22 14:57:05, darin wrote: > Looks good, but I'm not so sure about running ...
11 years, 4 months ago (2009-08-22 17:11:17 UTC) #3
darin (slow to review)
On 2009/08/22 17:11:17, Mike Belshe wrote: > On 2009/08/22 14:57:05, darin wrote: > > Looks ...
11 years, 4 months ago (2009-08-22 18:58:11 UTC) #4
Mike Belshe
OK - done. On 2009/08/22 18:58:11, darin wrote: > On 2009/08/22 17:11:17, Mike Belshe wrote: ...
11 years, 4 months ago (2009-08-23 16:51:24 UTC) #5
darin (slow to review)
11 years, 4 months ago (2009-08-23 19:00:17 UTC) #6
Very nice!  LGTM

Powered by Google App Engine
This is Rietveld 408576698