Update the Idle collector to do a full GC

Update the Idle collector to do a full GC
after being idle for some time.

Remove the default argument from CollectAllGarbage.


Committed: http://code.google.com/p/v8/source/detail?r=2748

[Erik Corry, 2009-08-23 21:35:34]

http://codereview.chromium.org/174302/diff/5/1006
File src/heap.h (right):

http://codereview.chromium.org/174302/diff/5/1006#newcode843
Line 843: // called repeatedly without JS activity, it will
It looks like this sentence hasn't been

http://codereview.chromium.org/174302/diff/5/1006#newcode857
Line 857: CollectAllGarbage();
If the idle notification keep coming, will this do lots of garbage collections? 
We need some way to determine whether any non-trivial work has taken place since
the last time we did an idle-loop garbage collection.  Otherwise V8 will be a
battery-killer on laptops.

[Mike Belshe, 2009-08-24 15:04:25]

On 2009/08/23 21:35:34, Erik Corry wrote:
> http://codereview.chromium.org/174302/diff/5/1006
> File src/heap.h (right):
> 
> http://codereview.chromium.org/174302/diff/5/1006#newcode843
> Line 843: // called repeatedly without JS activity, it will
> It looks like this sentence hasn't been

fixed :-)

> 
> http://codereview.chromium.org/174302/diff/5/1006#newcode857
> Line 857: CollectAllGarbage();
> If the idle notification keep coming, will this do lots of garbage
collections? 
> We need some way to determine whether any non-trivial work has taken place
since
> the last time we did an idle-loop garbage collection.  Otherwise V8 will be a
> battery-killer on laptops.

Updated the API to return a bool after compaction; I've modified the browser
side to detect that and stop calling (until the tab goes un-idle first).

[Mads Ager (chromium), 2009-08-24 15:29:27]

LGTM

http://codereview.chromium.org/174302/diff/12/1019
File src/heap.h (right):

http://codereview.chromium.org/174302/diff/12/1019#newcode858
Line 858: CollectAllGarbage();
Maybe we should force compaction here to reduce the size even further?  Last
week I put in a change to shrink new space on compactions.  I believe that
passing true to CollectAllGarbage will force a compaction.