Issue 1743004: Windows OSMesa DLL only exports OSMesa functions....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1743004: Windows OSMesa DLL only exports OSMesa functions.... (Closed)

Created:
10 years, 8 months ago by apatrick_chromium

Modified:
9 years, 7 months ago

Reviewers:
Ken Russell (switch to Gerrit)

CC:
chromium-reviews

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Windows OSMesa DLL only exports OSMesa functions. It no longer exports all the GL functions like glClear. These are bound by calling OSMesaGetProcAddress. glew no longer uses default mangled export name bind to OSMesaGetProcAddress. TEST=trybots, check the pepper 3d plugin demos still work on windows BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45618

Patch Set 1 #

Total comments: 2

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -7 lines)			Patch
M	third_party/glew/src/glew.c	View	1 chunk	+1 line, -1 line	0 comments	Download
M	third_party/mesa/MesaLib/src/mesa/drivers/osmesa/osmesa.def	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	third_party/mesa/README.chromium	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	third_party/mesa/mesa.gyp	View	2 chunks	+1 line, -6 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ken Russell (switch to Gerrit)

LGTM http://codereview.chromium.org/1743004/diff/1/3 File third_party/mesa/mesa.gyp (right): http://codereview.chromium.org/1743004/diff/1/3#newcode442 third_party/mesa/mesa.gyp:442: 'MesaLib/src/mesa/drivers/osmesa/osmesa.def', Will this be filtered out on non-Windows ...

10 years, 8 months ago (2010-04-22 23:17:51 UTC) #2

apatrick_chromium

10 years, 8 months ago (2010-04-22 23:19:42 UTC) #3

http://codereview.chromium.org/1743004/diff/1/3
File third_party/mesa/mesa.gyp (right):

http://codereview.chromium.org/1743004/diff/1/3#newcode442
third_party/mesa/mesa.gyp:442: 'MesaLib/src/mesa/drivers/osmesa/osmesa.def',
I believe it will be ignored on other platforms in the same way as files with
the _win.cc suffix. I am waiting for the trybots to confirm.

Expand Messages | Collapse Messages