Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 174250: Fix StackTrace on Windows.... (Closed)

Created:
11 years, 4 months ago by M-A Ruel
Modified:
9 years, 7 months ago
Reviewers:
awong
CC:
chromium-reviews_googlegroups.com, brettw
Visibility:
Public.

Description

Fix StackTrace on Windows. The previous implementation was overly verbose. The new one is now functional and the unit test now works. TEST=unit_test BUG=none

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -73 lines) Patch
M base/debug_util_unittest.cc View 2 chunks +6 lines, -10 lines 1 comment Download
M base/debug_util_win.cc View 4 chunks +23 lines, -63 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
11 years, 4 months ago (2009-08-21 20:46:41 UTC) #1
awong
http://codereview.chromium.org/174250/diff/1/3 File base/debug_util_unittest.cc (right): http://codereview.chromium.org/174250/diff/1/3#newcode22 Line 22: ASSERT_GE(frames_found, 5u) << Did you mean to make ...
11 years, 4 months ago (2009-08-21 20:52:20 UTC) #2
M-A Ruel
On 2009/08/21 20:52:20, awong wrote: > http://codereview.chromium.org/174250/diff/1/3 > File base/debug_util_unittest.cc (right): > > http://codereview.chromium.org/174250/diff/1/3#newcode22 > ...
11 years, 4 months ago (2009-08-21 20:54:47 UTC) #3
awong
11 years, 4 months ago (2009-08-21 20:56:26 UTC) #4
LGTM

Sounds good to me.  If it starts failing, we can always flip it back.

Powered by Google App Engine
This is Rietveld 408576698