Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 174239: Change download items' "Reveal in Finder" menu item to "Show in Finder" (Closed)

Created:
11 years, 4 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
Nico, gl
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Change download items' "Reveal in Finder" menu item to "Show in Finder". BUG=19943 TEST=Download something, click on the item's triangle, and read the menu items r24213

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M chrome/app/nibs/DownloadItem.xib View 5 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mark Mentovai
11 years, 4 months ago (2009-08-21 18:44:11 UTC) #1
Nico
LGTM I wonder why I went with "Reveal" – I bet I saw this somewhere, ...
11 years, 4 months ago (2009-08-25 03:18:14 UTC) #2
gl
11 years, 4 months ago (2009-08-25 04:47:50 UTC) #3
I'll tell you why: the key combination for this in most apps command-R.

On 2009/08/25 03:18:14, Nico wrote:
> LGTM
> 
> I wonder why I went with "Reveal" – I bet I saw this somewhere, but everything
I
> look at now uses "Show" :-P

Powered by Google App Engine
This is Rietveld 408576698