Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 1742018: Clean upstart for factory test (Closed)

Created:
10 years, 7 months ago by Nick Sanders
Modified:
9 years, 7 months ago
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://git@chromiumos-git/chromeos
Visibility:
Public.

Description

Clean upstart for factory test * Leave ui.conf there, not run by default. * dump autotest log into /dev/tty1 * Don't let tty1 eat keayboard events.

Patch Set 1 #

Total comments: 7
Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -37 lines) Patch
D src/scripts/mod_for_factory_scripts/100disableUI View 1 chunk +0 lines, -8 lines 0 comments Download
M src/scripts/mod_for_factory_scripts/200patchInitScript View 2 chunks +26 lines, -29 lines 7 comments Download

Messages

Total messages: 5 (0 generated)
Nick Sanders
10 years, 7 months ago (2010-04-29 23:21:50 UTC) #1
Tom Wai-Hong Tam
LGTM. It's great that easily to see the autotest output. http://codereview.chromium.org/1742018/diff/1/3 File src/scripts/mod_for_factory_scripts/200patchInitScript (right): http://codereview.chromium.org/1742018/diff/1/3#newcode18 ...
10 years, 7 months ago (2010-04-30 02:45:30 UTC) #2
Tammo Spalink
Yes, very nice. On 2010/04/30 02:45:30, Tom Wai-Hong Tam wrote: > LGTM. It's great that ...
10 years, 7 months ago (2010-04-30 03:28:34 UTC) #3
kmixter1
LGTM http://codereview.chromium.org/1742018/diff/1/3 File src/scripts/mod_for_factory_scripts/200patchInitScript (right): http://codereview.chromium.org/1742018/diff/1/3#newcode19 src/scripts/mod_for_factory_scripts/200patchInitScript:19: +start on never Isn't having no start on ...
10 years, 7 months ago (2010-04-30 19:20:12 UTC) #4
Nick Sanders
10 years, 7 months ago (2010-05-04 03:41:26 UTC) #5
http://codereview.chromium.org/1742018/diff/1/3
File src/scripts/mod_for_factory_scripts/200patchInitScript (right):

http://codereview.chromium.org/1742018/diff/1/3#newcode19
src/scripts/mod_for_factory_scripts/200patchInitScript:19: +start on never
On 2010/04/30 19:20:12, kmixter1 wrote:
> Isn't having no start on stanza equivalent?

Not sure, but this makes it clear on first glance that ui.conf will not start

http://codereview.chromium.org/1742018/diff/1/3#newcode75
src/scripts/mod_for_factory_scripts/200patchInitScript:75: tail -F
/var/log/factory.log > /dev/tty1
On 2010/04/30 19:20:12, kmixter1 wrote:
> So text mode is up on VT1 until X is started?  Who starts X now that keyboard
> test I know does not?

The keyboard test still starts X, as of now. Tammo is working on pulling out X
start into upstart.

Powered by Google App Engine
This is Rietveld 408576698