Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1252)

Issue 1742017: Add --reset-to-deps and improve comments (Closed)

Created:
10 years, 7 months ago by Nasser Grainawi
Modified:
9 years, 7 months ago
Reviewers:
djmm, M-A Ruel
CC:
chromium-reviews, M-A Ruel
Visibility:
Public.

Description

Make gclient.git.revert reset to DEPS revision BUG=http://crosbug.com/2897 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46113

Patch Set 1 #

Patch Set 2 : fixed the presubmit tests #

Patch Set 3 : modify gclient.git.revert instead #

Total comments: 1

Patch Set 4 : fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -12 lines) Patch
M gclient_scm.py View 1 2 3 1 chunk +10 lines, -3 lines 0 comments Download
M tests/gclient_scm_test.py View 2 3 chunks +16 lines, -8 lines 0 comments Download
M tests/scm_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Nasser Grainawi
10 years, 7 months ago (2010-04-29 22:39:53 UTC) #1
Nasser Grainawi
10 years, 7 months ago (2010-04-29 22:41:37 UTC) #2
djmm
LGTM! Thanks a lot Nasser for doing this.
10 years, 7 months ago (2010-04-29 22:43:45 UTC) #3
Marc-Antoine Ruel (Google)
I don't understand, how is it different than gclient revert? Le 29 avr. 2010 18:43, ...
10 years, 7 months ago (2010-04-29 23:00:29 UTC) #4
Nasser Grainawi
Hmm, guess it shouldn't be different, though git is doing something different for gclient revert ...
10 years, 7 months ago (2010-04-29 23:07:20 UTC) #5
Nasser Grainawi
10 years, 7 months ago (2010-04-29 23:14:37 UTC) #6
djmm
I suppose it's no different to run two commands, though as slow as gclient runs ...
10 years, 7 months ago (2010-04-29 23:17:38 UTC) #7
Nasser Grainawi
M-A, PTAL
10 years, 7 months ago (2010-04-30 15:33:25 UTC) #8
M-A Ruel
lgtm, much better than the original solution. http://codereview.chromium.org/1742017/diff/9001/10001 File gclient_scm.py (right): http://codereview.chromium.org/1742017/diff/9001/10001#newcode409 gclient_scm.py:409: if deps_revision.startswith('refs/heads/'): ...
10 years, 7 months ago (2010-04-30 15:46:35 UTC) #9
djmm
LGTM
10 years, 7 months ago (2010-04-30 20:02:49 UTC) #10
Nasser Grainawi
djmm@chromium.org wrote: > LGTM > > http://codereview.chromium.org/1742017/show It's failing a few tests right now that ...
10 years, 7 months ago (2010-04-30 20:07:15 UTC) #11
Nasser Grainawi
10 years, 7 months ago (2010-04-30 20:40:38 UTC) #12
M-A Ruel
10 years, 7 months ago (2010-04-30 20:57:00 UTC) #13
lgtm

Powered by Google App Engine
This is Rietveld 408576698