Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Issue 1742012: Port of date and timezone fixes from bleeding edge to... (Closed)

Created:
10 years, 8 months ago by Erik Corry
Modified:
9 years, 7 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Port of date and timezone fixes from bleeding edge to partial snapshots branch. http://codereview.chromium.org/1576002 r4326 Fix time zone cache so it is not initialized when the snapshot is built. http://codereview.chromium.org/1543008 r4332 Update the time zone offset and dst offset when time zone name changes. http://codereview.chromium.org/1539009 r4342 Modify date printing to fetch time zone name before converting to local time, so that the two agree. Fix a problem in DateToTimeString() time zone calculation. Committed: http://code.google.com/p/v8/source/detail?r=4530

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -9 lines) Patch
M src/date.js View 8 chunks +47 lines, -9 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
10 years, 8 months ago (2010-04-28 10:55:43 UTC) #1
William Hesse
10 years, 8 months ago (2010-04-28 11:09:51 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698