Issue 1742007: Enables EventSource and disables one layout test temporarily.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1742007: Enables EventSource and disables one layout test temporarily. (Closed)

Created:
10 years, 8 months ago by bulach

Modified:
9 years, 6 months ago

Reviewers:
dglazkov

CC:
chromium-reviews, darin-cc_chromium.org, dpranke+watch_chromium.org, pam+watch_chromium.org

Visibility:
Public.

Description

Enables EventSource and disables fast/dom/prototype-inheritance.htm temporarily. Once we roll to http://trac.webkit.org/changeset/58099, remove the layout test suppression. (follow up on http://codereview.chromium.org/557037/show which was reverted by http://codereview.chromium.org/1712006/show) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45324

Patch Set 1 #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -0 lines)			Patch
	M	build/features_override.gypi	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	webkit/tools/layout_tests/test_expectations.txt	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dglazkov

LGTM. Just to warn you. This may not be the only test you'll fail here. ...

10 years, 8 months ago (2010-04-22 16:54:12 UTC) #2

bulach

10 years, 8 months ago (2010-04-22 16:57:21 UTC) #3

thanks for the quick review, Dimitri!

I landed this a couple of hours ago, and coincidentally I'm a sheriff
today, so hopefully won't break twice.. ;)
I will obviously keep an eye on it anyway..

On Thu, Apr 22, 2010 at 5:54 PM,  <dglazkov@chromium.org> wrote:
> LGTM. Just to warn you. This may not be the only test you'll fail here. Land
> with care.
>
>
> http://codereview.chromium.org/1742007/show
>

Expand Messages | Collapse Messages