Issue 174171: Move NSAutoreleasePool management into the PlatformTest constructor and...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174171: Move NSAutoreleasePool management into the PlatformTest constructor and... (Closed)

Created:
11 years, 4 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com, John Grabowski

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Move NSAutoreleasePool management into the PlatformTest constructor and destructor. The pool operations are moving from SetUp and TearDown, which are scoped slightly too narrowly for our needs. Using the constructor and destructor ensures that the pools properly bracket tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23897

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -10 lines)			Patch
M	testing/gtest.gyp	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	testing/platform_test.h	View	1 chunk	+6 lines, -6 lines	0 comments	Download
M	testing/platform_test_mac.mm	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

I don't know what's wrong with me today. This should not have taken a half ...

11 years, 4 months ago (2009-08-20 21:13:20 UTC) #1

LGTM

Expand Messages | Collapse Messages