Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 174154: Enable -fstrict-aliasing in the GYP build of V8 for the Mac in Release mode (Closed)

Created:
11 years, 4 months ago by Mark Mentovai
Modified:
9 years, 7 months ago
Reviewers:
Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Enable -fstrict-aliasing in the GYP build of V8 for the Mac in Release mode. -fstrict-aliasing is enabled by mainline gcc at -O2 and higher, but in Apple gcc, it must be enabled explicitly. This results in a 1.5% improvement in V8 benchmark scores. This also removes the -fno-exceptions and -fno-rtti settings from v8.gyp for the Mac, and removes -fno-rtti from v8.gyp for Linux, because these settings have become part of Chromium's common.gypi, included here, as of r23304 at the latest. The settings in v8.gyp have become redundant. Committed: http://code.google.com/p/v8/source/detail?r=2734

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M tools/gyp/v8.gyp View 1 5 chunks +12 lines, -15 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Mark Mentovai
11 years, 4 months ago (2009-08-20 19:11:06 UTC) #1
Kasper Lund
11 years, 4 months ago (2009-08-20 19:12:21 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698