Do not finish GlobalHandles::PostGarbageCollectionProcessing if weak callback...

src/heap.cc

 // Copyright 2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 467 matching lines @@
   if (collector == MARK_COMPACTOR && global_gc_epilogue_callback_) {
     ASSERT(!allocation_allowed_);
     global_gc_epilogue_callback_();
   }
   VerifySymbolTable();
 }
 
 
 void Heap::PostGarbageCollectionProcessing() {
   // Process weak handles post gc.
+  bool old_value = allow_allocation(true);
   GlobalHandles::PostGarbageCollectionProcessing();
+  if (!old_value) allow_allocation(false);

[Mads Ager (chromium), 2009/08/21 05:58:16]

Just call allow_allocation with old_value?

   // Update flat string readers.
   FlatStringReader::PostGarbageCollectionProcessing();
 }
 
 
 void Heap::MarkCompact(GCTracer* tracer) {
   gc_state_ = MARK_COMPACT;
   mc_count_++;
   tracer->set_full_gc_count(mc_count_);
   LOG(ResourceEvent("markcompact", "begin"));
@@ skipping 3416 matching lines @@
 #ifdef DEBUG
 bool Heap::GarbageCollectionGreedyCheck() {
   ASSERT(FLAG_gc_greedy);
   if (Bootstrapper::IsActive()) return true;
   if (disallow_allocation_failure()) return true;
   return CollectGarbage(0, NEW_SPACE);
 }
 #endif
 
 } }  // namespace v8::internal