Fix Issue 19689: Command line URL parameter does not support Chinese....

Fix Issue 19689: Command line URL parameter does not support Chinese.

This CL fixes issue 19689 by handling command line values with native encoding on non-Windows systems.
For Linux, native encoding specified in current locale is used.
For Mac, UTF-8 will always be used.

This CL only changes command line values and program name to use native encoding, command line switches still use ASCII.

BUG=19689
: Command line URL parameter does not support Chinese
TEST=Execute chrome with "http://www.google.com/search?q=中文" to see if this url can be opened successfully.



Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24423

[James Su, 2009-08-20 12:01:57]

I just noticed this issue and made a simple patch for it.

Regards
James Su

[Evan Martin, 2009-08-20 13:27:06]

I think the proper thing to use here is the stuff in sys_string_conversions,
which ought to obey your locale (which, when it's UTF-8, will do the right thing
here).  I think Dean or Brett would know more.

[James Su, 2009-08-20 15:23:14]

Yes, sys_string_conversions would be more proper for Linux. Not sure if it's
suitable for Mac.

Regards
James Su

On 2009/08/20 13:27:06, Evan Martin wrote:
> I think the proper thing to use here is the stuff in sys_string_conversions,
> which ought to obey your locale (which, when it's UTF-8, will do the right
thing
> here).  I think Dean or Brett would know more.

[tony, 2009-08-20 19:04:25]

Adding jungshik, although I imagine sys_string_conversions will be fine for
linux.

[jungshik at Google, 2009-08-20 21:11:44]

On 2009/08/20 19:04:25, tony wrote:
> Adding jungshik, although I imagine sys_string_conversions will be fine for
> linux.

Although it'd not work always in theory, we don't have any better choice. And,
if UTF-8 has become a de factor standard these days (as it should have become a
long time ago), we have even less to worry about.

On Mac, it should also work there. sys_... is just a wrapper over To/FromUTF8.
Mac is better than Linux in that there's no way to use encodings other than
UTF-8.

[James Su, 2009-08-21 00:42:14]

Thanks for your comments. I'll update this CL asap.

James Su

On 2009/08/20 21:11:44, Jungshik Shin wrote:
> On 2009/08/20 19:04:25, tony wrote:
> > Adding jungshik, although I imagine sys_string_conversions will be fine for
> > linux.
> 
> Although it'd not work always in theory, we don't have any better choice. And,
> if UTF-8 has become a de factor standard these days (as it should have become
a
> long time ago), we have even less to worry about.
> 
> On Mac, it should also work there. sys_... is just a wrapper over To/FromUTF8.
> Mac is better than Linux in that there's no way to use encodings other than
> UTF-8.

[James Su, 2009-08-21 02:49:03]

CL has been updated to use functions in sys_string_conversions. I found that
setlocale was not called in our code explicitly, so I modified ChromeMain to
call setlocale before initializing CommandLine. Please help check if it's
correct.

Regards
James Su

On 2009/08/21 00:42:14, James Su wrote:
> Thanks for your comments. I'll update this CL asap.
> 
> James Su
> 
> On 2009/08/20 21:11:44, Jungshik Shin wrote:
> > On 2009/08/20 19:04:25, tony wrote:
> > > Adding jungshik, although I imagine sys_string_conversions will be fine
for
> > > linux.
> > 
> > Although it'd not work always in theory, we don't have any better choice.
And,
> > if UTF-8 has become a de factor standard these days (as it should have
become
> a
> > long time ago), we have even less to worry about.
> > 
> > On Mac, it should also work there. sys_... is just a wrapper over
To/FromUTF8.
> > Mac is better than Linux in that there's no way to use encodings other than
> > UTF-8.

[James Su, 2009-08-26 01:03:12]

ping.

On 2009/08/21 02:49:03, James Su wrote:
> CL has been updated to use functions in sys_string_conversions. I found that
> setlocale was not called in our code explicitly, so I modified ChromeMain to
> call setlocale before initializing CommandLine. Please help check if it's
> correct.
> 
> Regards
> James Su
> 
> On 2009/08/21 00:42:14, James Su wrote:
> > Thanks for your comments. I'll update this CL asap.
> > 
> > James Su
> > 
> > On 2009/08/20 21:11:44, Jungshik Shin wrote:
> > > On 2009/08/20 19:04:25, tony wrote:
> > > > Adding jungshik, although I imagine sys_string_conversions will be fine
> for
> > > > linux.
> > > 
> > > Although it'd not work always in theory, we don't have any better choice.
> And,
> > > if UTF-8 has become a de factor standard these days (as it should have
> become
> > a
> > > long time ago), we have even less to worry about.
> > > 
> > > On Mac, it should also work there. sys_... is just a wrapper over
> To/FromUTF8.
> > > Mac is better than Linux in that there's no way to use encodings other
than
> > > UTF-8.

[Evan Martin, 2009-08-26 01:05:40]

LGTM

http://codereview.chromium.org/174139/diff/1007/9
File chrome/app/chrome_dll_main.cc (right):

http://codereview.chromium.org/174139/diff/1007/9#newcode332
Line 332: // set c library locale to make sure CommandLine can parse argument
values
Can you capitalize properly?
E.g. "Set C library ... "

[Evan Martin, 2009-08-26 01:05:59]

Oh, and can you update the description?  You no longer rely on UTF-8 explicitly.

[James Su, 2009-08-26 01:16:13]

On 2009/08/26 01:05:59, Evan Martin wrote:
> Oh, and can you update the description?  You no longer rely on UTF-8
explicitly.

CL updated.

Regards
James Su

[James Su, 2009-08-26 01:17:15]

http://codereview.chromium.org/174139/diff/1007/9
File chrome/app/chrome_dll_main.cc (right):

http://codereview.chromium.org/174139/diff/1007/9#newcode332
Line 332: // set c library locale to make sure CommandLine can parse argument
values
On 2009/08/26 01:05:40, Evan Martin wrote:
> Can you capitalize properly?
> E.g. "Set C library ... "

Done.

[Evan Martin, 2009-08-26 01:23:12]

LGTM++