Issue 174106: Linux: make the "change proxy settings" button able to start several proxy config utilities.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174106: Linux: make the "change proxy settings" button able to start several proxy config utilities. (Closed)

Created:
11 years, 4 months ago by Mike Mammarella

Modified:
9 years, 7 months ago

Reviewers:
sdoyon, mattm

CC:
chromium-reviews_googlegroups.com, brettw, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Linux: make the "change proxy settings" button able to start several proxy config utilities. Currently it still only ever starts gnome-network-properties but it is now easy to update. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23910

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 3

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+124 lines, -52 lines)			Patch
M	base/linux_util.h	View	1 2	2 chunks	+10 lines, -1 line	0 comments	Download
M	base/linux_util.cc	View	1 2	2 chunks	+25 lines, -3 lines	0 comments	Download
M	chrome/browser/gtk/options/advanced_contents_gtk.cc	View	1 2	3 chunks	+87 lines, -47 lines	3 comments	Download
M	net/proxy/proxy_config_service_linux.cc	View	2	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mike Mammarella

Split off from the earlier change. New KDE parts commented out.

11 years, 4 months ago (2009-08-20 00:04:20 UTC) #1

mattm

lgtm http://codereview.chromium.org/174106/diff/8/12 File chrome/browser/gtk/options/advanced_contents_gtk.cc (right): http://codereview.chromium.org/174106/diff/8/12#newcode326 Line 326: static bool SearchPATH(ProxyConfigCommand* commands, size_t ncommands, should ...

11 years, 4 months ago (2009-08-20 22:56:23 UTC) #2

Mike Mammarella

11 years, 4 months ago (2009-08-20 23:11:59 UTC) #3

http://codereview.chromium.org/174106/diff/8/12
File chrome/browser/gtk/options/advanced_contents_gtk.cc (right):

http://codereview.chromium.org/174106/diff/8/12#newcode398
Line 398: if (!found_command) {
On 2009/08/20 22:56:23, mattm wrote:
> minor nit, but I think it's cleaner to swap the order of the if/else so the
test
> is just if (found_command)

Done.

Expand Messages | Collapse Messages