Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5521)

Unified Diff: build/common.gypi

Issue 1741010: gyp: unify toolkit_views usage (Closed)
Patch Set: Created 10 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 163cf9ba841162ebf608e97f858596600941033e..37390599a5c5eaab87eb8f06ed9232232b27ad24 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -268,7 +268,7 @@
}, {
'linux_dump_symbols%': 0,
}],
- ['toolkit_views==0 and chromeos==0', {
+ ['toolkit_views==0', {
# GTK wants Title Case strings
'use_titlecase_in_grd_files%': 1,
}],
@@ -388,7 +388,7 @@
}, { # else: branding!="Chrome"
'defines': ['CHROMIUM_BUILD'],
}],
- ['toolkit_views==1 or chromeos==1', {
+ ['toolkit_views==1', {
'defines': ['TOOLKIT_VIEWS=1'],
}],
['chromeos==1', {
@@ -545,7 +545,7 @@
['chromeos!=1', {
'sources/': [ ['exclude', '_chromeos\\.cc$'] ]
}],
- ['OS!="win" and (toolkit_views==0 and chromeos==0)', {
+ ['toolkit_views==0', {
'sources/': [ ['exclude', '_views\\.cc$'] ]
}],
],
@@ -923,7 +923,7 @@
'-mfpmath=sse',
],
}],
- # ChromeOS targets Pinetrail, which is ssse3, but most of the
+ # ChromeOS targets Pinetrail, which is sse3, but most of the
# benefit comes from sse2 so this setting allows ChromeOS
# to build on other CPUs. In the future -march=atom would help
# but requires a newer compiler.
« no previous file with comments | « build/all.gyp ('k') | chrome/chrome_browser.gypi » ('j') | chrome/chrome_exe.gypi » ('J')

Powered by Google App Engine
This is Rietveld 408576698