Issue 174052: Reapply the semispace growth policy change in isolation....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 174052: Reapply the semispace growth policy change in isolation.... (Closed)

Created:
11 years, 4 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
Kasper Lund

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Reapply the semispace growth policy change in isolation. Additionally fix NewSpace capacity bug by removing the duplicated capacity and maximum capacity book keeping. The capacity and maximum capacity of NewSpace is the capacity and maximum capacity of one of it's semispaces. Submitted as r2717.

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+39 lines, -28 lines)			Patch
M	src/heap.cc	View		1 chunk	+3 lines, -3 lines	0 comments	Download
M	src/spaces.h	View		5 chunks	+19 lines, -10 lines	0 comments	Download
M	src/spaces.cc	View	1	5 chunks	+17 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kasper Lund

LGTM. http://codereview.chromium.org/174052/diff/1/4 File src/spaces.cc (right): http://codereview.chromium.org/174052/diff/1/4#newcode1083 Line 1083: int extra = RoundUp(capacity_ / 2, OS::AllocateAlignment()); ...

11 years, 4 months ago (2009-08-19 09:16:51 UTC) #2

Mads Ager (chromium)

11 years, 4 months ago (2009-08-19 09:23:55 UTC) #3

On 2009/08/19 09:16:51, Kasper Lund wrote:
> LGTM.
> 
> http://codereview.chromium.org/174052/diff/1/4
> File src/spaces.cc (right):
> 
> http://codereview.chromium.org/174052/diff/1/4#newcode1083
> Line 1083: int extra = RoundUp(capacity_ / 2, OS::AllocateAlignment());
> How about using Min(RoundUp(...), maximum_capacity - capacity)?

Good idea.  Done.

Expand Messages | Collapse Messages