Issue 17402: Python library for writing data pack files (see base/data_pack*).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 17402: Python library for writing data pack files (see base/data_pack*). (Closed)

Created:
11 years, 11 months ago by Evan Martin

Modified:
9 years, 7 months ago

Reviewers:
tony, agl

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Python library for writing data pack files (see base/data_pack*).

Patch Set 1 #

Total comments: 2

Created: 11 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -0 lines)			Patch
	A	tools/data_pack/DataPack.py	View		1 chunk	+42 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

Not sure where this belongs. Also notice I don't NUL-terminate anything. I think it should ...

11 years, 11 months ago (2009-01-08 00:40:04 UTC) #2

tony

11 years, 11 months ago (2009-01-08 00:44:53 UTC) #4

LGTM.  I think the current location is fine.  It'll probably get rolled into
grit.

http://codereview.chromium.org/17402/diff/1/2
File tools/data_pack/DataPack.py (right):

http://codereview.chromium.org/17402/diff/1/2#newcode1
Line 1: #!/usr/bin/python
Nit: this file should be named data_pack.py or something.

http://codereview.chromium.org/17402/diff/1/2#newcode37
Line 37: data = { 1: "", 4: "this is id 4", 6: "this is id 6", 10: "" }
Maybe include some embedded nulls?

Expand Messages | Collapse Messages