Windows bots build and use OSMesa...

Windows bots build and use OSMesa

This is a software GL renderer that can be used by bots that do not have access to native GL. It will be used for running tests that use GL, such as Pepper 3D, WebGL and accelerated compositing. Only working on Windows so far.

TEST=trybots
BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45241

[Nicolas Sylvain, 2010-04-21 17:16:03]

Try bots are not using that configuration, so they did not test it. I think you
also need to add it to the main section in all.gyp if you want them to test it. 

the current code lgtm, feel free to commit when you feel confident that it works

[apatrick, 2010-04-21 18:47:13]

The Windows trybots appeared to build osmesa. Search for "osmesa.c" in
http://build.chromium.org/buildbot/try-server/builders/win/builds/28691/steps....
I don't want to add it to the main section of all.gyp because then everyone
will have to build it after clobbering, which takes a fair amount of time,
and because then they will be using a slower software renderer when using
the 3D accelerated features of Chrome like WebGL.

On Wed, Apr 21, 2010 at 10:16 AM, <nsylvain@chromium.org> wrote:

> Try bots are not using that configuration, so they did not test it. I think
> you
> also need to add it to the main section in all.gyp if you want them to test
> it.
>
> the current code lgtm, feel free to commit when you feel confident that it
> works
>
>
> http://codereview.chromium.org/1740001/show
>

[Nicolas Sylvain, 2010-04-22 00:00:18]

On Wed, Apr 21, 2010 at 11:47 AM, Alastair Patrick <apatrick@google.com>wrote:

> The Windows trybots appeared to build osmesa. Search for "osmesa.c" in
>
http://build.chromium.org/buildbot/try-server/builders/win/builds/28691/steps....
> I don't want to add it to the main section of all.gyp because then everyone
> will have to build it after clobbering, which takes a fair amount of time,
> and because then they will be using a slower software renderer when using
> the 3D accelerated features of Chrome like WebGL.

The try bots should be building the main section of all.gyp. So if this is
built, users who build all.gyp will also get it.  (except windows users who
build chrome.sln instead of all.sln... or linux users who build chrome
instead of all)

Nicolas


>
> On Wed, Apr 21, 2010 at 10:16 AM, <nsylvain@chromium.org> wrote:
>
>> Try bots are not using that configuration, so they did not test it. I
>> think you
>> also need to add it to the main section in all.gyp if you want them to
>> test it.
>>
>> the current code lgtm, feel free to commit when you feel confident that it
>> works
>>
>>
>> http://codereview.chromium.org/1740001/show
>>
>
>