Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Issue 17395: - Match up w/ NSPasteboard docs and mark sure our special type is on the... (Closed)

Created:
11 years, 11 months ago by TVL
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

- Match up w/ NSPasteboard docs and mark sure our special type is on the pastboard type list before we put the marker. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=8092

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M base/clipboard_mac.mm View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
TVL
11 years, 11 months ago (2009-01-13 20:49:29 UTC) #1
pink (ping after 24hrs)
LGTM
11 years, 11 months ago (2009-01-13 20:52:45 UTC) #2
Avi (use Gerrit)
Uh, OK. LGTM, but why does it matter?
11 years, 11 months ago (2009-01-13 21:04:50 UTC) #3
TVL
11 years, 11 months ago (2009-01-13 21:08:50 UTC) #4
On 2009/01/13 21:04:50, Avi wrote:
> Uh, OK. LGTM, but why does it matter?

If the type wasn't declared, you shouldn't be able to push it onto the
pasteboard.  So depending on how you try to collect the data back, it can fail,
it happens that some collection types work and other don't; so this forces it to
be inline w/ the docs so things always work as one would expect.

Powered by Google App Engine
This is Rietveld 408576698