Issue 1739021: Modify scm.GIT.GetUpstreamBranch to behave like git-cl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1739021: Modify scm.GIT.GetUpstreamBranch to behave like git-cl. (Closed)

Created:
10 years, 7 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin, sky

CC:
chromium-reviews

Visibility:
Public.

Description

Modify scm.GIT.GetUpstreamBranch to behave like git-cl. It now defaults to origin/master when no branch is tracked. TEST=git-try on untracked branch now doesn't result in an empty diff BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=45935

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+27 lines, -9 lines)			Patch
M	gclient_scm.py	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	scm.py	View	4 chunks	+12 lines, -3 lines	0 comments	Download
M	tests/scm_unittest.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/trychange_unittest.py	View	2 chunks	+4 lines, -2 lines	0 comments	Download
M	trychange.py	View	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

One side-effect I'm unhappy is that it will use the index changes and will silently ...

10 years, 7 months ago (2010-04-29 16:02:16 UTC) #3

LGTM

Expand Messages | Collapse Messages