Avoiding the assumption that the pc pointer of RelocInfo points to the word c...

Avoiding the assumption that the pc pointer of RelocInfo points to the word containing the target address. It wasn't true for ARM. (One step closer to serialization on ARM).

Committed: http://code.google.com/p/v8/source/detail?r=1067

[Mads Ager (chromium), 2009-01-13 14:26:10]

LGTM

http://codereview.chromium.org/17376/diff/1/6
File src/serialize.cc (right):

http://codereview.chromium.org/17376/diff/1/6#newcode592
Line 592: "StackGuard::address_of_limit()");
RegexpStackGuard?

http://codereview.chromium.org/17376/diff/1/2
File test/cctest/test-serialize.cc (right):

http://codereview.chromium.org/17376/diff/1/2#newcode112
Line 112: CHECK_EQ(make_code(UNCLASSIFIED, 5),
Do you want to have a test for index 4 here as well?

http://codereview.chromium.org/17376/diff/1/2#newcode144
Line 144: decoder.Decode(make_code(UNCLASSIFIED, 5)));
Ditto.

[olehougaard, 2009-01-13 14:35:22]

http://codereview.chromium.org/17376/diff/1/6
File src/serialize.cc (right):

http://codereview.chromium.org/17376/diff/1/6#newcode592
Line 592: "StackGuard::address_of_limit()");
On 2009/01/13 14:26:10, Mads Ager wrote:
> RegexpStackGuard?

Fixed.

http://codereview.chromium.org/17376/diff/1/2
File test/cctest/test-serialize.cc (right):

http://codereview.chromium.org/17376/diff/1/2#newcode112
Line 112: CHECK_EQ(make_code(UNCLASSIFIED, 5),
On 2009/01/13 14:26:10, Mads Ager wrote:
> Do you want to have a test for index 4 here as well?

Not really. A few samples should be sufficient or we'll need
to change this test too often.

http://codereview.chromium.org/17376/diff/1/2#newcode144
Line 144: decoder.Decode(make_code(UNCLASSIFIED, 5)));
On 2009/01/13 14:26:10, Mads Ager wrote:
> Ditto.

Ditto :)