Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1737023: Turn some usages of NewArray with DeleteArray in the same scope into ScopedVector or SmartPointer. (Closed)

Created:
10 years, 7 months ago by antonm
Modified:
9 years, 4 months ago
CC:
v8-dev
Visibility:
Public.

Description

Turn some usages of NewArray with DeleteArray in the same scope into ScopedVector or SmartPointer. That makes it easier to maintain the code---one should care less about releasing the memory as smart pointers would take care of this. Switch to ScopedVector instead Vector for the same semantics in src/builtins.cc Committed: http://code.google.com/p/v8/source/detail?r=4593

Patch Set 1 #

Patch Set 2 : Remove one unnecessary space #

Patch Set 3 : Disabling implicit constructors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -66 lines) Patch
M src/api.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M src/builtins.cc View 2 chunks +1 line, -2 lines 0 comments Download
M src/debug.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M src/debug-agent.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/flags.cc View 3 chunks +5 lines, -9 lines 0 comments Download
M src/log.cc View 1 2 chunks +2 lines, -5 lines 0 comments Download
M src/objects.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M src/platform-freebsd.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M src/platform-linux.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M src/platform-macos.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M src/platform-solaris.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M src/platform-win32.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M src/utils.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
antonm
Kasper, Mads and Misha, may you have a look? I'm just fulfilling the promise :)
10 years, 7 months ago (2010-04-30 15:49:18 UTC) #1
mnaganov (inactive)
On 2010/04/30 15:49:18, antonm wrote: > Kasper, Mads and Misha, > > may you have ...
10 years, 7 months ago (2010-04-30 21:09:28 UTC) #2
antonm
10 years, 7 months ago (2010-05-04 19:33:11 UTC) #3
Very nice idea, Michail, done.

I'll commit it tomorrow to track all the build breakages it might introduce.

Powered by Google App Engine
This is Rietveld 408576698