Rename Compare -> Comparator to resolve name conflict in v8::internal

Rename Compare -> Comparator to resolve name conflict in v8::internal

Committed: http://code.google.com/p/v8/source/detail?r=4520

[Evan Martin, 2010-04-23 19:43:43]

http://codereview.chromium.org/1737009/diff/2001/3002
File src/liveedit.h (right):

http://codereview.chromium.org/1737009/diff/2001/3002#newcode121
src/liveedit.h:121: class Comparator {
Since nothing else in the header needed to change when you renamed this, I guess
that means it is only used within liveedit.cc?  You might consider putting this
class in the .cc file in an anonymous namespace.

[Peter Rybin, 2010-04-23 19:51:49]

http://codereview.chromium.org/1737009/diff/2001/3002
File src/liveedit.h (right):

http://codereview.chromium.org/1737009/diff/2001/3002#newcode121
src/liveedit.h:121: class Comparator {
On 2010/04/23 19:43:43, Evan Martin wrote:
> Since nothing else in the header needed to change when you renamed this, I
guess
> that means it is only used within liveedit.cc?  You might consider putting
this
> class in the .cc file in an anonymous namespace.

I think I would make it difficult to test this class. What would you say?

[Evan Martin, 2010-04-23 20:07:24]

On 2010/04/23 19:51:49, Peter Rybin wrote:
> http://codereview.chromium.org/1737009/diff/2001/3002
> File src/liveedit.h (right):
> 
> http://codereview.chromium.org/1737009/diff/2001/3002#newcode121
> src/liveedit.h:121: class Comparator {
> On 2010/04/23 19:43:43, Evan Martin wrote:
> > Since nothing else in the header needed to change when you renamed this, I
> guess
> > that means it is only used within liveedit.cc?  You might consider putting
> this
> > class in the .cc file in an anonymous namespace.
> 
> I think I would make it difficult to test this class. What would you say?

Good point!  Another option to consider is a separate "liveedit" namespace, but
I don't think it matters too much.  This LGTM either way.