Issue 173625: Move object allocation in new space to macro assembler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173625: Move object allocation in new space to macro assembler (Closed)

Created:
11 years, 3 months ago by Søren Thygesen Gjesse

Modified:
9 years, 7 months ago

Reviewers:
Erik Corry

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Move object allocation in new space to macro assembler Currently allocation in generated code on ARM is only used for allocating heap numbers. This change factors this out for use in upcomming changes. Committed: http://code.google.com/p/v8/source/detail?r=2789

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+66 lines, -28 lines)			Patch
M	src/arm/codegen-arm.cc	View	1 2	1 chunk	+13 lines, -28 lines	0 comments	Download
M	src/arm/macro-assembler-arm.h	View	1	1 chunk	+14 lines, -0 lines	0 comments	Download
M	src/arm/macro-assembler-arm.cc	View		2 chunks	+39 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Erik Corry

LGTM http://codereview.chromium.org/173625/diff/1004/1006 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/173625/diff/1004/1006#newcode4951 Line 4951: // Allocate an object in the haep ...

11 years, 3 months ago (2009-08-31 15:03:28 UTC) #2

Søren Thygesen Gjesse

11 years, 3 months ago (2009-09-01 10:21:39 UTC) #3

http://codereview.chromium.org/173625/diff/1004/1006
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/173625/diff/1004/1006#newcode4951
Line 4951: // Allocate an object in the haep for the heap number and tag it as a
heap
On 2009/08/31 15:03:29, Erik Corry wrote:
> haep -> heap

Done.

Expand Messages | Collapse Messages