Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Issue 17362: Pixel perfection on OTR icon. The tabstrip is still positioned/sized wrong r... (Closed)

Created:
11 years, 11 months ago by Peter Kasting
Modified:
9 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Pixel perfection on OTR icon. The tabstrip is still positioned/sized wrong relative to the OTR icon, sadly. Much of the issue here is because the OTR image was a child view in the old code and isn't in the new. As a result, we have to: * Change the drawing order to draw the OTR image after the tabstrip (like a child view would normally have been drawn), so the tabstrip's semi-transparent pixels don't overlay it * Change the bounds calculation and drawing code to clip the image properly in maximized mode (where a child view would have been clipped naturally) Since I changed the calling order of the OTR functions, I also changed their declaration/definition order to follow suit. This also tries to rename a few constants to be more consistent. I can't figure out how to make any of these read nicely :( BUG=5054 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7908

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -40 lines) Patch
M chrome/browser/views/frame/opaque_non_client_view.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/views/frame/opaque_non_client_view.cc View 10 chunks +61 lines, -38 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Peter Kasting
11 years, 11 months ago (2009-01-12 23:23:48 UTC) #1
sky
11 years, 11 months ago (2009-01-13 00:28:53 UTC) #2
OK

Powered by Google App Engine
This is Rietveld 408576698