Chromium Code Reviews
DescriptionPixel perfection on OTR icon. The tabstrip is still positioned/sized wrong relative to the OTR icon, sadly.
Much of the issue here is because the OTR image was a child view in the old code and isn't in the new. As a result, we have to:
* Change the drawing order to draw the OTR image after the tabstrip (like a child view would normally have been drawn), so the tabstrip's semi-transparent pixels don't overlay it
* Change the bounds calculation and drawing code to clip the image properly in maximized mode (where a child view would have been clipped naturally)
Since I changed the calling order of the OTR functions, I also changed their declaration/definition order to follow suit.
This also tries to rename a few constants to be more consistent. I can't figure out how to make any of these read nicely :(
BUG=5054
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=7908
Patch Set 1 #
Messages
Total messages: 2 (0 generated)
|
||||||||||||||||||||||||||||