Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Side by Side Diff: src/arm/codegen-arm.cc

Issue 1736018: Fix presubmit errors (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 336 matching lines...) Expand 10 before | Expand all | Expand 10 after
347 frame_->Exit(); 347 frame_->Exit();
348 348
349 // Here we use masm_-> instead of the __ macro to avoid the code coverage 349 // Here we use masm_-> instead of the __ macro to avoid the code coverage
350 // tool from instrumenting as we rely on the code size here. 350 // tool from instrumenting as we rely on the code size here.
351 int32_t sp_delta = (scope()->num_parameters() + 1) * kPointerSize; 351 int32_t sp_delta = (scope()->num_parameters() + 1) * kPointerSize;
352 masm_->add(sp, sp, Operand(sp_delta)); 352 masm_->add(sp, sp, Operand(sp_delta));
353 masm_->Jump(lr); 353 masm_->Jump(lr);
354 354
355 #ifdef DEBUG 355 #ifdef DEBUG
356 // Check that the size of the code used for returning matches what is 356 // Check that the size of the code used for returning matches what is
357 // expected by the debugger. If the sp_delts above cannot be encoded in th e 357 // expected by the debugger. If the sp_delts above cannot be encoded in
358 // add instruction the add will generate two instructions. 358 // the add instruction the add will generate two instructions.
359 int return_sequence_length = 359 int return_sequence_length =
360 masm_->InstructionsGeneratedSince(&check_exit_codesize); 360 masm_->InstructionsGeneratedSince(&check_exit_codesize);
361 CHECK(return_sequence_length == Assembler::kJSReturnSequenceLength || 361 CHECK(return_sequence_length == Assembler::kJSReturnSequenceLength ||
362 return_sequence_length == Assembler::kJSReturnSequenceLength + 1); 362 return_sequence_length == Assembler::kJSReturnSequenceLength + 1);
363 #endif 363 #endif
364 } 364 }
365 } 365 }
366 366
367 // Adjust for function-level loop nesting. 367 // Adjust for function-level loop nesting.
368 ASSERT(loop_nesting_ == info->loop_nesting()); 368 ASSERT(loop_nesting_ == info->loop_nesting());
(...skipping 4870 matching lines...) Expand 10 before | Expand all | Expand 10 after
5239 5239
5240 void DeferredReferenceGetNamedValue::Generate() { 5240 void DeferredReferenceGetNamedValue::Generate() {
5241 __ DecrementCounter(&Counters::named_load_inline, 1, r1, r2); 5241 __ DecrementCounter(&Counters::named_load_inline, 1, r1, r2);
5242 __ IncrementCounter(&Counters::named_load_inline_miss, 1, r1, r2); 5242 __ IncrementCounter(&Counters::named_load_inline_miss, 1, r1, r2);
5243 5243
5244 // Setup the name register and call load IC. 5244 // Setup the name register and call load IC.
5245 __ mov(r2, Operand(name_)); 5245 __ mov(r2, Operand(name_));
5246 5246
5247 // The rest of the instructions in the deferred code must be together. 5247 // The rest of the instructions in the deferred code must be together.
5248 { Assembler::BlockConstPoolScope block_const_pool(masm_); 5248 { Assembler::BlockConstPoolScope block_const_pool(masm_);
5249
5250 Handle<Code> ic(Builtins::builtin(Builtins::LoadIC_Initialize)); 5249 Handle<Code> ic(Builtins::builtin(Builtins::LoadIC_Initialize));
5251 __ Call(ic, RelocInfo::CODE_TARGET); 5250 __ Call(ic, RelocInfo::CODE_TARGET);
5252 // The call must be followed by a nop(1) instruction to indicate that the 5251 // The call must be followed by a nop(1) instruction to indicate that the
5253 // in-object has been inlined. 5252 // in-object has been inlined.
5254 __ nop(NAMED_PROPERTY_LOAD_INLINED); 5253 __ nop(NAMED_PROPERTY_LOAD_INLINED);
5255 5254
5256 // Block the constant pool for one more instruction after leaving this 5255 // Block the constant pool for one more instruction after leaving this
5257 // constant pool block scope to include the branch instruction ending the 5256 // constant pool block scope to include the branch instruction ending the
5258 // deferred code. 5257 // deferred code.
5259 __ BlockConstPoolFor(1); 5258 __ BlockConstPoolFor(1);
(...skipping 4089 matching lines...) Expand 10 before | Expand all | Expand 10 after
9349 9348
9350 // Just jump to runtime to add the two strings. 9349 // Just jump to runtime to add the two strings.
9351 __ bind(&string_add_runtime); 9350 __ bind(&string_add_runtime);
9352 __ TailCallRuntime(Runtime::kStringAdd, 2, 1); 9351 __ TailCallRuntime(Runtime::kStringAdd, 2, 1);
9353 } 9352 }
9354 9353
9355 9354
9356 #undef __ 9355 #undef __
9357 9356
9358 } } // namespace v8::internal 9357 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698