Issue 1736006: Changing filebrowser to append a number on the end of an existing directory....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1736006: Changing filebrowser to append a number on the end of an existing directory.... (Closed)

Created:
10 years, 8 months ago by dhg

Modified:
9 years, 7 months ago

Reviewers:
xiyuan

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Changing filebrowser to append a number on the end of an existing directory. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46004

Patch Set 2 : '' #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -2 lines)			Patch
	M	chrome/browser/resources/filebrowse.html	View	1	3 chunks	+15 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

xiyuan

http://codereview.chromium.org/1736006/diff/1/2 File chrome/browser/resources/filebrowse.html (right): http://codereview.chromium.org/1736006/diff/1/2#newcode877 chrome/browser/resources/filebrowse.html:877: while (existingfolder) { I wonder what existingfolder would be ...

10 years, 8 months ago (2010-04-23 21:35:24 UTC) #2

dhg

Good catch. Done. On 2010/04/23 21:35:24, xiyuan wrote: > http://codereview.chromium.org/1736006/diff/1/2 > File chrome/browser/resources/filebrowse.html (right): > ...

10 years, 8 months ago (2010-04-26 16:17:34 UTC) #3