Issue 1736005: build: Re-hide pointless question in image_to_usb.sh --test_image.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1736005: build: Re-hide pointless question in image_to_usb.sh --test_image. (Closed)

Created:
10 years, 8 months ago by Daniel Erat

Modified:
9 years, 7 months ago

Reviewers:
sosa

CC:
chromium-os-reviews_chromium.org, Nick Sanders

Visibility:
Public.

Description

build: Re-hide pointless question in image_to_usb.sh --test_image. Undoes a change from 5c3b457f. Hardcoding "--yes" in the call to mod_image_for_test.sh instead of inheriting image_to_usb.sh's "yes" was intentional. The user may not pass --yes to image_to_usb.sh since they want to confirm that they're writing to the correct device, but they already told us that they want the image to be modified for test with --test_image, so there's no reason to ask about it again. BUG=none TEST=ran it

Patch Set 1 #

Patch Set 2 : add comment #

Created: 10 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -7 lines)			Patch
	M	src/scripts/image_to_usb.sh	View	1	1 chunk	+4 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nick Sanders

Can we get the default device deleted as well? /dev/sdb is typically a second (development) ...

10 years, 8 months ago (2010-04-23 05:18:10 UTC) #3

Daniel Erat

10 years, 8 months ago (2010-04-24 01:33:47 UTC) #4

Sure, this offends me too.  Change is on the way.

On Thu, Apr 22, 2010 at 10:17 PM, Nick Sanders <nsanders@chromium.org> wrote:
> Can we get the default device deleted as well? /dev/sdb is typically a
> second (development) HDD, and there's no particular standard for where USB
> devices land.
>
> On Thu, Apr 22, 2010 at 1:37 PM, <sosa@chromium.org> wrote:
>>
>> jumping in on this one.  lgtm
>>
>> http://codereview.chromium.org/1736005/show
>
>

Expand Messages | Collapse Messages