Rolled up change to wireless test suite for OpenWRT.

Rolled up change to wireless test suite for OpenWRT.

[Sam Leffler, 2010-04-21 15:36:12]

http://codereview.chromium.org/1736001/diff/1/2
File server/site_linux_router.py (right):

http://codereview.chromium.org/1736001/diff/1/2#newcode74
server/site_linux_router.py:74: self.configured = False
Add a comment about how you handle hostapd configuration using a global state
block that you updated based on config requests.  Or maybe below in the config
method...

http://codereview.chromium.org/1736001/diff/1/2#newcode102
server/site_linux_router.py:102: ignore_status=True)
Why are you ignoring status; seems like if this fails you've got a problem?

http://codereview.chromium.org/1736001/diff/1/3
File server/site_wifitest.py (right):

http://codereview.chromium.org/1736001/diff/1/3#newcode179
server/site_wifitest.py:179: assoc_timeout = ''' + params.get('assoc_timeout',
"60") + '''
Leave a TODO marker indicating something is wrong that we need a 60 second
timeout on associate.

[neb, 2010-04-21 20:46:40]

http://codereview.chromium.org/1736001/diff/1/2
File server/site_linux_router.py (right):

http://codereview.chromium.org/1736001/diff/1/2#newcode74
server/site_linux_router.py:74: self.configured = False
On 2010/04/21 15:36:12, Sam Leffler wrote:
> Add a comment about how you handle hostapd configuration using a global state
> block that you updated based on config requests.  Or maybe below in the config
> method...

Done.

http://codereview.chromium.org/1736001/diff/1/2#newcode102
server/site_linux_router.py:102: ignore_status=True)
On 2010/04/21 15:36:12, Sam Leffler wrote:
> Why are you ignoring status; seems like if this fails you've got a problem?

Done.

http://codereview.chromium.org/1736001/diff/1/3
File server/site_wifitest.py (right):

http://codereview.chromium.org/1736001/diff/1/3#newcode179
server/site_wifitest.py:179: assoc_timeout = ''' + params.get('assoc_timeout',
"60") + '''
On 2010/04/21 15:36:12, Sam Leffler wrote:
> Leave a TODO marker indicating something is wrong that we need a 60 second
> timeout on associate.

Done.

[Sam Leffler, 2010-04-21 21:52:53]

LGTM modulo nits; you can defer to the next CL if you want since this is only
being run by us

http://codereview.chromium.org/1736001/diff/13001/14001
File server/site_linux_router.py (right):

http://codereview.chromium.org/1736001/diff/13001/14001#newcode154
server/site_linux_router.py:154: else
missing : (you said it's already fixed but for the record)

http://codereview.chromium.org/1736001/diff/13001/14001#newcode210
server/site_linux_router.py:210: elif k == 'pureg' or k == 'puren' or k ==
'wepmode' or k == 'rifs':
80 cols?