Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 173568: Add allocation support to x64 macro assembler (Closed)

Created:
11 years, 3 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
Lasse Reichstein
CC:
v8-dev
Visibility:
Public.

Description

Add allocation support to x64 macro assembler. Factored out the allocation in new space from assembler code into the macro assembler for x64 as was recently done for ia32. Added set property svn:eol-style to native for all x64 files. Committed: http://code.google.com/p/v8/source/detail?r=2778

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+207 lines, -20 lines) Patch
M src/ia32/builtins-ia32.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M src/ia32/macro-assembler-ia32.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/assembler-x64.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/x64/assembler-x64.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/x64/assembler-x64-inl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
MM src/x64/builtins-x64.cc View 4 chunks +14 lines, -24 lines 0 comments Download
M src/x64/cfg-x64.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/x64/codegen-x64.h View 0 chunks +-1 lines, --1 lines 0 comments Download
MM src/x64/codegen-x64.cc View 1 chunk +9 lines, -13 lines 0 comments Download
M src/x64/codegen-x64-inl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/x64/cpu-x64.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/x64/debug-x64.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/x64/disasm-x64.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/x64/frames-x64.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/x64/frames-x64.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/x64/ic-x64.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/x64/jump-target-x64.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
MM src/x64/macro-assembler-x64.h View 1 2 chunks +49 lines, -0 lines 0 comments Download
MM src/x64/macro-assembler-x64.cc View 1 chunk +152 lines, -0 lines 0 comments Download
M src/x64/regexp-macro-assembler-x64.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/x64/regexp-macro-assembler-x64.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/x64/register-allocator-x64.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/x64/register-allocator-x64.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/x64/register-allocator-x64-inl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/x64/simulator-x64.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/x64/simulator-x64.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/x64/virtual-frame-x64.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M src/x64/virtual-frame-x64.cc View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
11 years, 3 months ago (2009-08-27 14:14:57 UTC) #1
Lasse Reichstein
LGTM http://codereview.chromium.org/173568/diff/1/5 File src/x64/macro-assembler-x64.h (right): http://codereview.chromium.org/173568/diff/1/5#newcode234 Line 234: // result_contains_top_on_entry is true the contnt of ...
11 years, 3 months ago (2009-08-28 05:11:20 UTC) #2
Søren Thygesen Gjesse
11 years, 3 months ago (2009-08-28 06:35:06 UTC) #3
http://codereview.chromium.org/173568/diff/1/5
File src/x64/macro-assembler-x64.h (right):

http://codereview.chromium.org/173568/diff/1/5#newcode234
Line 234: // result_contains_top_on_entry is true the contnt of result is known
to be
On 2009/08/28 05:11:20, Lasse Reichstein wrote:
> "contnt" -> "content"

Done.

Powered by Google App Engine
This is Rietveld 408576698