Issue 173566: Port apply with arguments optimization to x64.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173566: Port apply with arguments optimization to x64. (Closed)

Created:
11 years, 3 months ago by Mads Ager (chromium)

Modified:
9 years, 7 months ago

Reviewers:
William Hesse

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Port apply with arguments optimization to x64. Committed: http://code.google.com/p/v8/source/detail?r=2776

Patch Set 2 : '' #

Total comments: 3

Created: 11 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+230 lines, -39 lines)			Patch
	M	src/x64/codegen-x64.h	View		1 chunk	+8 lines, -0 lines	0 comments	Download
	M	src/x64/codegen-x64.cc	View	1	3 chunks	+222 lines, -39 lines	3 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

William Hesse

LGTM. http://codereview.chromium.org/173566/diff/1003/7 File src/x64/codegen-x64.cc (right): http://codereview.chromium.org/173566/diff/1003/7#newcode729 Line 729: Result tmp = allocator_->Allocate(); You can use ...

11 years, 3 months ago (2009-08-27 14:38:25 UTC) #2

Mads Ager (chromium)

11 years, 3 months ago (2009-08-27 14:56:31 UTC) #3

Thanks!

http://codereview.chromium.org/173566/diff/1003/7
File src/x64/codegen-x64.cc (right):

http://codereview.chromium.org/173566/diff/1003/7#newcode729
Line 729: Result tmp = allocator_->Allocate();
On 2009/08/27 14:38:25, William Hesse wrote:
> You can use kScratchRegister here, in CmpObjectType.

Done.

Expand Messages | Collapse Messages

Issue 173566: Port apply with arguments optimization to x64. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages