Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 173550: linux: scan more plugin directories, fix bugs (Closed)

Created:
11 years, 3 months ago by Evan Martin
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

linux: scan more plugin directories, fix bugs We now scan more directories, sort file entries by mtime, use realpath() before loading plugins (fixes a Java bug), and de-duplicate multiple instances of the same plugin. This matches the Mozilla plugin loading code more closely. We also ignore xpcom-related errors while loading plugins, as that breaks layout tests. I encountered this while attempting to fix QuickTime (need to load the Totem plugins) but the fix overlaps with the Java one. I believe neither quite work yet, though. BUG=16787, 19712 TEST=about:plugins should show more plugins

Patch Set 1 #

Patch Set 2 : cleanups #

Patch Set 3 : fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -13 lines) Patch
M base/native_library_linux.cc View 1 chunk +8 lines, -2 lines 0 comments Download
M webkit/glue/plugins/plugin_list_linux.cc View 1 2 2 chunks +65 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Evan Martin
11 years, 3 months ago (2009-08-27 00:28:27 UTC) #1
Evan Martin
+tschmelcher, who suggested scanning extra dirs
11 years, 3 months ago (2009-08-27 00:28:58 UTC) #2
piman
LGTM. I'm not convinced about the well-foundedness of the order-by-time scheme, but since that's what ...
11 years, 3 months ago (2009-08-27 00:50:19 UTC) #3
Tristan Schmelcher
LGTM
11 years, 3 months ago (2009-08-27 01:03:25 UTC) #4
Evan Martin
Retry on review. See changes in native_library_linux as well as patchset 2 on the main ...
11 years, 3 months ago (2009-08-27 22:50:30 UTC) #5
Tristan Schmelcher
LGTM
11 years, 3 months ago (2009-08-27 23:05:52 UTC) #6
piman
11 years, 3 months ago (2009-08-27 23:56:45 UTC) #7
LGTM

Powered by Google App Engine
This is Rietveld 408576698