Do not cache functions until we know they are fully constructed.

src/apinatives.js

 // Copyright 2006-2008 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 41 matching lines @@
       var result = Constructor ? new (Instantiate(Constructor))() : {};
       ConfigureTemplateInstance(result, data);
       return result;
     default:
       throw 'Unknown API tag <' + tag + '>';
   }
 }
 
 
 function InstantiateFunction(data, name) {
+  // We need a reference to kApiFunctionCache in the stack frame
+  // if we need to bail out from a stack overflow.
+  var cache = kApiFunctionCache;
   var serialNumber = %GetTemplateField(data, kApiSerialNumberOffset);
-  if (!(serialNumber in kApiFunctionCache)) {
-    kApiFunctionCache[serialNumber] = null;
-    var fun = %CreateApiFunction(data);
-    if (name) %FunctionSetName(fun, name);
-    kApiFunctionCache[serialNumber] = fun;
-    var prototype = %GetTemplateField(data, kApiPrototypeTemplateOffset);
-    fun.prototype = prototype ? Instantiate(prototype) : {};
-    %SetProperty(fun.prototype, "constructor", fun, DONT_ENUM);
-    var parent = %GetTemplateField(data, kApiParentTemplateOffset);
-    if (parent) {
-      var parent_fun = Instantiate(parent);
-      fun.prototype.__proto__ = parent_fun.prototype;
+  var isFunctionCached =
+   (serialNumber in kApiFunctionCache) &&

[Mads Ager (chromium), 2009/01/13 07:00:39]

Use the local variable 'cache' throughout this function?

[olehougaard, 2009/01/13 07:13:05]

Fixed

+   (kApiFunctionCache[serialNumber] != -1);

[Mads Ager (chromium), 2009/01/13 07:00:39]

How about introducing a named constants in macros.py for the -1? 

[olehougaard, 2009/01/13 07:13:05]

I would, but I wouldn't be able to look it up in the exception handler, so
there's not much use for it.

[olehougaard, 2009/01/13 07:15:41]

Uh, this is rubbish. I guess I can introduce a constant in macros.py. I'll do it
in a separate cl.

+  if (!isFunctionCached) {
+    try {
+      kApiFunctionCache[serialNumber] = null;
+      var fun = %CreateApiFunction(data);
+      if (name) %FunctionSetName(fun, name);
+      kApiFunctionCache[serialNumber] = fun;
+      var prototype = %GetTemplateField(data, kApiPrototypeTemplateOffset);
+      fun.prototype = prototype ? Instantiate(prototype) : {};
+      %SetProperty(fun.prototype, "constructor", fun, DONT_ENUM);
+      var parent = %GetTemplateField(data, kApiParentTemplateOffset);
+      if (parent) {
+        var parent_fun = Instantiate(parent);
+        fun.prototype.__proto__ = parent_fun.prototype;
+      }
+      ConfigureTemplateInstance(fun, data);
+    } catch (e) {
+      cache[serialNumber] = -1;
+      throw e;
     }
-    ConfigureTemplateInstance(fun, data);
   }
   return kApiFunctionCache[serialNumber];
 }
 
 
 function ConfigureTemplateInstance(obj, data) {
   var properties = %GetTemplateField(data, kApiPropertyListOffset);
   if (properties) {
     // Disable access checks while instantiating the object.
     var requires_access_checks = %DisableAccessChecks(obj);
     try {
       for (var i = 0; i < properties[0]; i += 3) {
         var name = properties[i + 1];
         var prop_data = properties[i + 2];
         var attributes = properties[i + 3];
         var value = Instantiate(prop_data, name);
         %SetProperty(obj, name, value, attributes);
       }
     } finally {
       if (requires_access_checks) %EnableAccessChecks(obj);
     }
   }
 }