Do not cache functions until we know they are fully constructed.

Do not cache functions until we know they are fully constructed. This is needed in case of a stack overflow during construction.

Committed: http://code.google.com/p/v8/source/detail?r=1056

[Mads Ager (chromium), 2009-01-12 09:58:39]

LGTM

[Christian Plesner Hansen, 2009-01-12 09:59:02]

This causes recursive use of a function template to break.  For instance, if it
has a property that is an instance of itself then it will now it will lead to
infinite recursion.

[Mads Ager (chromium), 2009-01-13 07:00:39]

LGTM

http://codereview.chromium.org/17354/diff/203/8
File src/apinatives.js (right):

http://codereview.chromium.org/17354/diff/203/8#newcode67
Line 67: (serialNumber in kApiFunctionCache) &&
Use the local variable 'cache' throughout this function?

http://codereview.chromium.org/17354/diff/203/8#newcode68
Line 68: (kApiFunctionCache[serialNumber] != -1);
How about introducing a named constants in macros.py for the -1?

[olehougaard, 2009-01-13 07:13:05]

http://codereview.chromium.org/17354/diff/203/8
File src/apinatives.js (right):

http://codereview.chromium.org/17354/diff/203/8#newcode67
Line 67: (serialNumber in kApiFunctionCache) &&
On 2009/01/13 07:00:39, Mads Ager wrote:
> Use the local variable 'cache' throughout this function?

Fixed

http://codereview.chromium.org/17354/diff/203/8#newcode68
Line 68: (kApiFunctionCache[serialNumber] != -1);
On 2009/01/13 07:00:39, Mads Ager wrote:
> How about introducing a named constants in macros.py for the -1? 

I would, but I wouldn't be able to look it up in the exception handler, so
there's not much use for it.

[olehougaard, 2009-01-13 07:15:41]

http://codereview.chromium.org/17354/diff/203/8
File src/apinatives.js (right):

http://codereview.chromium.org/17354/diff/203/8#newcode68
Line 68: (kApiFunctionCache[serialNumber] != -1);
On 2009/01/13 07:13:05, olehougaard wrote:
> On 2009/01/13 07:00:39, Mads Ager wrote:
> > How about introducing a named constants in macros.py for the -1? 
> 
> I would, but I wouldn't be able to look it up in the exception handler, so
> there's not much use for it.

Uh, this is rubbish. I guess I can introduce a constant in macros.py. I'll do it
in a separate cl.