Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Issue 173506: Fix crash in Linux extension shelf. (Closed)

Created:
11 years, 4 months ago by Paweł Hajdan Jr.
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Fix crash in Linux extension shelf. We need to delay creating render view until we're fully constructed. TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24530

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -4 lines) Patch
M chrome/browser/extensions/extension_host.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/gtk/extension_view_gtk.h View 2 chunks +7 lines, -1 line 0 comments Download
M chrome/browser/gtk/extension_view_gtk.cc View 1 chunk +6 lines, -1 line 1 comment Download

Messages

Total messages: 2 (0 generated)
Paweł Hajdan Jr.
Looks like no one is running extension shelf on Linux. :( Reproduces very easily. Just ...
11 years, 4 months ago (2009-08-26 20:00:42 UTC) #1
Erik does not do reviews
11 years, 4 months ago (2009-08-26 20:13:26 UTC) #2
LGTM

http://codereview.chromium.org/173506/diff/1/3
File chrome/browser/gtk/extension_view_gtk.cc (right):

http://codereview.chromium.org/173506/diff/1/3#newcode19
Line 19: void ExtensionViewGtk::Init() {
I'm not sure I see the reason to split out the Init() method.  It looks like you
only call it right after calling new anyway.

Powered by Google App Engine
This is Rietveld 408576698