Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1735018: Added sync_tools.gyp to all.gyp. (Closed)

Created:
10 years, 8 months ago by akalin
Modified:
9 years, 7 months ago
Reviewers:
ncarter (slow)
CC:
chromium-reviews
Visibility:
Public.

Description

Added sync_tools.gyp to all.gyp. BUG=none TEST=trybots Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=46711

Patch Set 1 #

Patch Set 2 : Fixed order #

Patch Set 3 : Fixed windows compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -1 line) Patch
M build/all.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync/tools/sync_tools.gyp View 1 2 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
akalin
+nick for review
10 years, 8 months ago (2010-04-28 01:43:00 UTC) #1
akalin
Win failure looks legit, looking... On 2010/04/28 01:43:00, akalin wrote: > +nick for review
10 years, 8 months ago (2010-04-29 02:19:19 UTC) #2
akalin
Okay, fixed. PTAL. On 2010/04/29 02:19:19, akalin wrote: > Win failure looks legit, looking... > ...
10 years, 8 months ago (2010-04-29 02:33:30 UTC) #3
akalin
Ping! On 2010/04/29 02:33:30, akalin wrote: > Okay, fixed. PTAL. > > On 2010/04/29 02:19:19, ...
10 years, 7 months ago (2010-04-30 01:17:41 UTC) #4
ncarter (slow)
LGTM
10 years, 7 months ago (2010-04-30 18:20:09 UTC) #5
ncarter (slow)
Is this not checked in yet?
10 years, 7 months ago (2010-05-06 18:34:41 UTC) #6
akalin
10 years, 7 months ago (2010-05-07 17:48:30 UTC) #7
Ugh, I missed this.  Checking this in now.

On 2010/05/06 18:34:41, nick wrote:
> Is this not checked in yet?

Powered by Google App Engine
This is Rietveld 408576698