OLD | NEW |
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. |
2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
4 | 4 |
5 #include "chrome/browser/extensions/extension_l10n_util.h" | 5 #include "chrome/browser/extensions/extension_l10n_util.h" |
6 | 6 |
7 #include "base/file_path.h" | 7 #include "base/file_path.h" |
8 #include "base/file_util.h" | 8 #include "base/file_util.h" |
9 #include "base/scoped_ptr.h" | 9 #include "base/scoped_ptr.h" |
10 #include "base/scoped_temp_dir.h" | 10 #include "base/scoped_temp_dir.h" |
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
96 file_util::WriteFile(locale_2.AppendASCII(Extension::kMessagesFilename), | 96 file_util::WriteFile(locale_2.AppendASCII(Extension::kMessagesFilename), |
97 data.c_str(), data.length())); | 97 data.c_str(), data.length())); |
98 | 98 |
99 scoped_ptr<Extension> extension(CreateMinimalExtension("")); | 99 scoped_ptr<Extension> extension(CreateMinimalExtension("")); |
100 | 100 |
101 std::string error; | 101 std::string error; |
102 EXPECT_TRUE(extension_l10n_util::AddValidLocales(src_path, | 102 EXPECT_TRUE(extension_l10n_util::AddValidLocales(src_path, |
103 extension.get(), | 103 extension.get(), |
104 &error)); | 104 &error)); |
105 | 105 |
106 EXPECT_EQ(static_cast<unsigned int>(2), | 106 EXPECT_EQ(2U, extension->supported_locales().size()); |
107 extension->supported_locales().size()); | |
108 } | 107 } |
109 | 108 |
110 TEST(ExtensionL10nUtil, SetDefaultLocaleGoodDefaultLocaleInManifest) { | 109 TEST(ExtensionL10nUtil, SetDefaultLocaleGoodDefaultLocaleInManifest) { |
111 scoped_ptr<Extension> extension(CreateMinimalExtension("sr")); | 110 scoped_ptr<Extension> extension(CreateMinimalExtension("sr")); |
112 extension->AddSupportedLocale("sr"); | 111 extension->AddSupportedLocale("sr"); |
113 extension->AddSupportedLocale("en-US"); | 112 extension->AddSupportedLocale("en-US"); |
114 | 113 |
115 EXPECT_TRUE(extension_l10n_util::ValidateDefaultLocale(extension.get())); | 114 EXPECT_TRUE(extension_l10n_util::ValidateDefaultLocale(extension.get())); |
116 EXPECT_EQ("sr", extension->default_locale()); | 115 EXPECT_EQ("sr", extension->default_locale()); |
117 } | 116 } |
118 | 117 |
119 TEST(ExtensionL10nUtil, SetDefaultLocaleNoDefaultLocaleInManifest) { | 118 TEST(ExtensionL10nUtil, SetDefaultLocaleNoDefaultLocaleInManifest) { |
120 scoped_ptr<Extension> extension(CreateMinimalExtension("")); | 119 scoped_ptr<Extension> extension(CreateMinimalExtension("")); |
121 extension->AddSupportedLocale("sr"); | 120 extension->AddSupportedLocale("sr"); |
122 extension->AddSupportedLocale("en-US"); | 121 extension->AddSupportedLocale("en-US"); |
123 | 122 |
124 EXPECT_FALSE(extension_l10n_util::ValidateDefaultLocale(extension.get())); | 123 EXPECT_FALSE(extension_l10n_util::ValidateDefaultLocale(extension.get())); |
125 } | 124 } |
126 | 125 |
127 TEST(ExtensionL10nUtil, SetDefaultLocaleWrongDefaultLocaleInManifest) { | 126 TEST(ExtensionL10nUtil, SetDefaultLocaleWrongDefaultLocaleInManifest) { |
128 scoped_ptr<Extension> extension(CreateMinimalExtension("ko")); | 127 scoped_ptr<Extension> extension(CreateMinimalExtension("ko")); |
129 extension->AddSupportedLocale("sr"); | 128 extension->AddSupportedLocale("sr"); |
130 extension->AddSupportedLocale("en-US"); | 129 extension->AddSupportedLocale("en-US"); |
131 | 130 |
132 EXPECT_FALSE(extension_l10n_util::ValidateDefaultLocale(extension.get())); | 131 EXPECT_FALSE(extension_l10n_util::ValidateDefaultLocale(extension.get())); |
133 } | 132 } |
134 | 133 |
| 134 TEST(ExtensionL10nUtil, LoadMessageCatalogsMissingFiles) { |
| 135 scoped_ptr<Extension> extension(CreateMinimalExtension("en-US")); |
| 136 extension->AddSupportedLocale("sr"); |
| 137 extension->AddSupportedLocale("en-US"); |
| 138 extension->set_application_locale("sr"); |
| 139 |
| 140 ScopedTempDir temp; |
| 141 ASSERT_TRUE(temp.CreateUniqueTempDir()); |
| 142 |
| 143 FilePath src_path = temp.path().AppendASCII(Extension::kLocaleFolder); |
| 144 ASSERT_TRUE(file_util::CreateDirectory(src_path)); |
| 145 |
| 146 std::string error; |
| 147 EXPECT_FALSE(extension_l10n_util::LoadMessageCatalogs(src_path, |
| 148 extension.get(), |
| 149 &error)); |
| 150 EXPECT_FALSE(error.empty()); |
| 151 } |
| 152 |
| 153 TEST(ExtensionL10nUtil, LoadMessageCatalogsBadJSONFormat) { |
| 154 scoped_ptr<Extension> extension(CreateMinimalExtension("en-US")); |
| 155 extension->AddSupportedLocale("sr"); |
| 156 extension->AddSupportedLocale("en-US"); |
| 157 extension->set_application_locale("sr"); |
| 158 |
| 159 ScopedTempDir temp; |
| 160 ASSERT_TRUE(temp.CreateUniqueTempDir()); |
| 161 |
| 162 FilePath src_path = temp.path().AppendASCII(Extension::kLocaleFolder); |
| 163 ASSERT_TRUE(file_util::CreateDirectory(src_path)); |
| 164 |
| 165 FilePath locale = src_path.AppendASCII("en_US"); |
| 166 ASSERT_TRUE(file_util::CreateDirectory(locale)); |
| 167 |
| 168 std::string data = "{ \"name\":"; |
| 169 ASSERT_TRUE( |
| 170 file_util::WriteFile(locale.AppendASCII(Extension::kMessagesFilename), |
| 171 data.c_str(), data.length())); |
| 172 |
| 173 std::string error; |
| 174 EXPECT_FALSE(extension_l10n_util::LoadMessageCatalogs(src_path, |
| 175 extension.get(), |
| 176 &error)); |
| 177 EXPECT_EQ("Line: 1, column: 10, Syntax error.", error); |
| 178 } |
| 179 |
| 180 TEST(ExtensionL10nUtil, LoadMessageCatalogsDuplicateKeys) { |
| 181 scoped_ptr<Extension> extension(CreateMinimalExtension("en-US")); |
| 182 extension->AddSupportedLocale("sr"); |
| 183 extension->AddSupportedLocale("en-US"); |
| 184 extension->set_application_locale("sr"); |
| 185 |
| 186 ScopedTempDir temp; |
| 187 ASSERT_TRUE(temp.CreateUniqueTempDir()); |
| 188 |
| 189 FilePath src_path = temp.path().AppendASCII(Extension::kLocaleFolder); |
| 190 ASSERT_TRUE(file_util::CreateDirectory(src_path)); |
| 191 |
| 192 FilePath locale_1 = src_path.AppendASCII("en_US"); |
| 193 ASSERT_TRUE(file_util::CreateDirectory(locale_1)); |
| 194 |
| 195 std::string data = |
| 196 "{ \"name\": { \"message\": \"something\" }, " |
| 197 "\"name\": { \"message\": \"something else\" } }"; |
| 198 ASSERT_TRUE( |
| 199 file_util::WriteFile(locale_1.AppendASCII(Extension::kMessagesFilename), |
| 200 data.c_str(), data.length())); |
| 201 |
| 202 FilePath locale_2 = src_path.AppendASCII("sr"); |
| 203 ASSERT_TRUE(file_util::CreateDirectory(locale_2)); |
| 204 |
| 205 ASSERT_TRUE( |
| 206 file_util::WriteFile(locale_2.AppendASCII(Extension::kMessagesFilename), |
| 207 data.c_str(), data.length())); |
| 208 |
| 209 std::string error; |
| 210 // JSON parser hides duplicates. We are going to get only one key/value |
| 211 // pair at the end. |
| 212 EXPECT_TRUE(extension_l10n_util::LoadMessageCatalogs(src_path, |
| 213 extension.get(), |
| 214 &error)); |
| 215 EXPECT_TRUE(error.empty()); |
| 216 EXPECT_EQ(1U, extension->message_handler()->GetDictionarySize()); |
| 217 } |
| 218 |
135 } // namespace | 219 } // namespace |
OLD | NEW |