Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: src/heap.cc

Issue 173471: Remove shrinking of new space on compaction and only do it on idle... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap.cc
===================================================================
--- src/heap.cc (revision 2761)
+++ src/heap.cc (working copy)
@@ -465,9 +465,9 @@
old_gen_allocation_limit_ =
old_gen_size + Max(kMinimumAllocationLimit, old_gen_size / 2);
old_gen_exhausted_ = false;
- } else {
- Scavenge();
}
+ Scavenge();
+
Counters::objs_since_last_young.Set(0);
PostGarbageCollectionProcessing();
@@ -521,12 +521,6 @@
Counters::objs_since_last_full.Set(0);
context_disposed_pending_ = false;
-
- Scavenge();
-
- // Shrink new space as much as possible after compacting full
- // garbage collections.
- if (is_compacting) new_space_.Shrink();
}
@@ -2807,6 +2801,8 @@
CollectAllGarbage(force_compaction);
last_gc_count = gc_count_;
if (force_compaction) {
+ // Shrink new space.
+ new_space_.Shrink();
number_idle_notifications = 0;
finished = true;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698