Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 173469: Handle pre-allocated properties when copying map (Closed)

Created:
11 years, 4 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Handle pre-allocated properties when copying map. When copying a map always set the descriptor array to describe the pre-allocated properties, even when descriptors are to be dropped. Added a test which otherwise failed with an assert on ARM in debug mode. The reason for it only surfasing on ARM is that the NewObject runtime function is always used for allocating new JSObjects on ARM. This change includes a few parts of http://codereview.chromium.org/174392 needed to trigger the error. Committed: http://code.google.com/p/v8/source/detail?r=2762

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -1 line) Patch
M src/compiler.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M src/objects.cc View 1 2 chunks +11 lines, -1 line 0 comments Download
M src/objects-debug.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/runtime.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M test/mjsunit/simple-constructor.js View 1 chunk +17 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Søren Thygesen Gjesse
11 years, 4 months ago (2009-08-26 10:58:54 UTC) #1
Mads Ager (chromium)
11 years, 4 months ago (2009-08-26 11:02:19 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698