Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 173465: Only pass idle notifications on from the API if V8 has been... (Closed)

Created:
11 years, 4 months ago by Mads Ager (chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Only pass idle notifications on from the API if V8 has been initialized. Minor cleanups. Committed: http://code.google.com/p/v8/source/detail?r=2757

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -32 lines) Patch
M src/api.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap.h View 1 chunk +1 line, -31 lines 0 comments Download
M src/heap.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M src/mark-compact.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-api.cc View 3 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Mads Ager (chromium)
11 years, 4 months ago (2009-08-26 08:08:49 UTC) #1
Søren Thygesen Gjesse
LGTM
11 years, 4 months ago (2009-08-26 08:10:57 UTC) #2
Mike Belshe
11 years, 4 months ago (2009-08-26 08:21:19 UTC) #3
LGTM2

On 2009/08/26 08:10:57, Søren Gjesse wrote:
> LGTM

Powered by Google App Engine
This is Rietveld 408576698