Issue 173456: Revert my download item change....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173456: Revert my download item change.... (Closed)

Created:
11 years, 4 months ago by Evan Stade

Modified:
9 years, 6 months ago

Reviewers:
levin

CC:
chromium-reviews_googlegroups.com, Paul Godavari, Ben Goodger (Google)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Revert my download item change. Turns out download item views need to be destroyed before the associated download item is destroyed. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24421

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -20 lines)			Patch
	M	chrome/browser/gtk/download_item_gtk.h	View		2 chunks	+0 lines, -5 lines	0 comments	Download
	M	chrome/browser/gtk/download_item_gtk.cc	View		5 chunks	+3 lines, -15 lines	0 comments	Download

Total messages: 2 (0 generated)

LGTM

thanks.