Issue 173447: Merge 24251 - Fixes bug where changing the src of an audio/video element woul...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173447: Merge 24251 - Fixes bug where changing the src of an audio/video element woul... (Closed)

Created:
11 years, 4 months ago by laforge

Modified:
9 years, 7 months ago

Reviewers:
scherkus (not reviewing)

CC:
chromium-reviews_googlegroups.com, fbarchard, Alpha Left Google, kylep, awong, darin (slow to review), scherkus (not reviewing)

Base URL:
svn://chrome-svn/chrome/branches/195/src/

Visibility:
Public.

Description

Merge 24251 - Fixes bug where changing the src of an audio/video element would stop firing events. HTMLMediaElement keeps track of network/ready state separately. When reusing an element by setting the src and calling load(), HTMLMediaElement's network/ready states became out of sync with the actual values inside WebMediaPlayerImpl. This led to the second media never firing 'loadedmetadata' and other events. BUG=16768, 20152 TEST=change src of an audio/video, call load(), should see durationchange and loadedmetadata events Review URL: http://codereview.chromium.org/174385 TBR=scherkus@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24401

Patch Set 1 #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -8 lines)			Patch
	MM	webkit/glue/webmediaplayer_impl.cc	View		1 chunk	+6 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages