Cache GTMTheme across windows to avoid re-creating it every time we create a ...

Cache GTMTheme across windows to avoid re-creating it every time we create a new window. Cache gradient to avoid re-creating it every time we draw a button cell.
BUG=none
TEST=switch themes, ensure it works. Make sure buttons draw correctly.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24441

[Mark Mentovai, 2009-08-26 01:25:49]

lg

http://codereview.chromium.org/173445/diff/1/2
File chrome/browser/cocoa/browser_window_controller.mm (right):

http://codereview.chromium.org/173445/diff/1/2#newcode1207
Line 1207: static std::map<ThemeKey, GTMTheme*> cache;
I think that every place we have a static that leaks its garbage we should put a
comment like "this might be a candidate for a Singleton or a LazyInstance" so
that if we ever decide we want to make things singletons or lazy instances, we
can go through and do them easily.

http://codereview.chromium.org/173445/diff/1/3
File chrome/browser/cocoa/gradient_button_cell.mm (right):

http://codereview.chromium.org/173445/diff/1/3#newcode35
Line 35: shouldTheme_ = YES;
Indent is weird.

[pink (ping after 24hrs), 2009-08-26 14:55:56]

http://codereview.chromium.org/173445/diff/1/2
File chrome/browser/cocoa/browser_window_controller.mm (right):

http://codereview.chromium.org/173445/diff/1/2#newcode1207
Line 1207: static std::map<ThemeKey, GTMTheme*> cache;
On 2009/08/26 01:25:49, Mark Mentovai wrote:
> I think that every place we have a static that leaks its garbage we should put
a
> comment like "this might be a candidate for a Singleton or a LazyInstance" so
> that if we ever decide we want to make things singletons or lazy instances, we
> can go through and do them easily.

Done.

http://codereview.chromium.org/173445/diff/1/3
File chrome/browser/cocoa/gradient_button_cell.mm (right):

http://codereview.chromium.org/173445/diff/1/3#newcode35
Line 35: shouldTheme_ = YES;
On 2009/08/26 01:25:49, Mark Mentovai wrote:
> Indent is weird.

Done.