Issue 173418: Avoids the use of ToWStringHack in a few places....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173418: Avoids the use of ToWStringHack in a few places.... (Closed)

Created:
11 years, 4 months ago by tfarina (gmail-do not use)

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Avoids the use of ToWStringHack in a few places. BUG=None TEST=run app_unittests.exe, browser_tests.exe and selenium_tests.exe Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24504

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -36 lines)			Patch
M	app/l10n_util_unittest.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	base/file_util_unittest.cc	View	2 3 4	4 chunks	+15 lines, -15 lines	0 comments	Download
M	chrome/browser/privacy_blacklist/blacklist_unittest.cc	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	chrome/test/selenium/selenium_test.cc	View		1 chunk	+9 lines, -9 lines	0 comments	Download
M	chrome/test/unit/chrome_test_suite.h	View	1	1 chunk	+1 line, -2 lines	0 comments	Download
M	webkit/tools/test_shell/test_shell_win.cc	View		2 chunks	+2 lines, -4 lines	0 comments	Download

Total messages: 2 (0 generated)

tfarina (gmail-do not use)

Hi Evan, could you take a look at this?

11 years, 4 months ago (2009-08-26 17:56:08 UTC) #1

LGTM, will try it now