Issue 173414: On a middle click, check if the mouse is over a scrollbar before pasting the ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 173414: On a middle click, check if the mouse is over a scrollbar before pasting the ... (Closed)

Created:
11 years, 4 months ago by vandebo (ex-Chrome)

Modified:
9 years, 7 months ago

Reviewers:
tony, Evan Stade

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

On a middle click, check if the mouse is over a scrollbar before pasting the selection. BUG=16400 TEST=See bug description Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24454

Total comments: 2

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -1 line)			Patch
	M	webkit/glue/webview_impl.cc	View	1 2 3	1 chunk	+5 lines, -1 line	0 comments	Download

Total messages: 6 (0 generated)

tony

Changing reviewers since I think estade wrote the original code.

11 years, 4 months ago (2009-08-26 00:41:40 UTC) #2

Evan Stade

yea, Steve asked me whether using the hit test and .scrollbar() functions was ok. I ...

11 years, 4 months ago (2009-08-26 00:58:51 UTC) #3

Evan Stade

sorry for all the style nits, lgtm (what's that function there for if not to ...

11 years, 4 months ago (2009-08-26 01:20:31 UTC) #5

vandebo (ex-Chrome)

11 years, 4 months ago (2009-08-26 16:19:48 UTC) #6

>   IntPoint click_point(bla, bla);  would be more concise

Indeed.  Done.