Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(149)

Issue 173394: git-try: Use trychange library for HTTP submits.... (Closed)

Created:
11 years, 3 months ago by chase
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

git-try: Use trychange library for HTTP submits. Make git-try use trychange for both SVN and HTTP try server submits. Simplifies git-try and reduces chance of differences in behavior between SVN and HTTP try job submits. Exit early if the checkout's configured email address does not pass validation. Simplify trychange import. BUG=none TEST=git-try submits a job to the try server Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=24315

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -72 lines) Patch
M git-try View 3 chunks +53 lines, -72 lines 1 comment Download

Messages

Total messages: 3 (0 generated)
chase
11 years, 3 months ago (2009-08-25 20:48:45 UTC) #1
M-A Ruel
http://codereview.chromium.org/173394/diff/1/2 File git-try (right): http://codereview.chromium.org/173394/diff/1/2#newcode167 Line 167: 'svn://svn.chromium.org/chrome-try/try', Err, you may break folks with that ...
11 years, 3 months ago (2009-08-25 20:56:50 UTC) #2
M-A Ruel
11 years, 3 months ago (2009-08-25 20:57:06 UTC) #3
On 2009/08/25 20:56:50, Marc-Antoine Ruel wrote:
> http://codereview.chromium.org/173394/diff/1/2
> File git-try (right):
> 
> http://codereview.chromium.org/173394/diff/1/2#newcode167
> Line 167: 'svn://svn.chromium.org/chrome-try/try',
> Err, you may break folks with that but I guess it's not a big deal for now,
> assuming you intent continuing to reduce even more this file to its simplest
> expression.


lgtm

Powered by Google App Engine
This is Rietveld 408576698