Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Unified Diff: webkit/glue/webmediaplayer_impl.cc

Issue 173388: Fix for audio/video not firing ended if you change src and call load(). (Closed)
Patch Set: Created 11 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/glue/webmediaplayer_impl.cc
diff --git a/webkit/glue/webmediaplayer_impl.cc b/webkit/glue/webmediaplayer_impl.cc
index 939603709f85db539eb3c3bae6c6f6a0629354c1..49d29e055479e21cf26cc29c9fc8e4683553c6ee 100644
--- a/webkit/glue/webmediaplayer_impl.cc
+++ b/webkit/glue/webmediaplayer_impl.cc
@@ -266,7 +266,11 @@ void WebMediaPlayerImpl::seek(float seconds) {
// seek(0) internally. Avoid doing seek(0) the second time because this will
// cause extra pre-rolling and will break servers without range request
// support.
+ //
+ // We still have to notify WebKit that time has changed otherwise
+ // HTMLMediaElement gets into an inconsistent state.
if (pipeline_->GetCurrentTime().ToInternalValue() == 0 && seconds == 0) {
+ GetClient()->timeChanged();
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698